chore: refactor get_configuration to use a dataclass
#1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've introduced a new `BenchmarkConfig` frozen dataclass to provide a more structured way of handling benchmark configurations. I updated the `get_configuration` function in `tests/benchmark/utils.py` to return an instance of this dataclass. I have partially updated the call sites for `get_configuration` to use the new dataclass object. The following directories have been updated: - tests/benchmark/db_benchmark/groupby/ - tests/benchmark/db_benchmark/join/ - tests/benchmark/db_benchmark/sort/ - tests/benchmark/read_gbq_colab/ (except for sort_output.py) The remaining call sites in `tests/benchmark/read_gbq_colab/sort_output.py` and `tests/benchmark/tpch/` still need to be updated.
This change introduces a new `BenchmarkConfig` frozen dataclass to provide a more structured way of handling benchmark configurations. The `get_configuration` function in `tests/benchmark/utils.py` will be updated to return an instance of this dataclass. All call sites for `get_configuration` will be updated to use the new dataclass object.
|
Presubmit failure unrelated. I'll rerun. We should really address those flakes. CC @GarrettWu I'm also running the benchmarks locally to double-check. So far, so good. |
This change introduces a new `BenchmarkConfig` frozen dataclass to provide a more structured way of handling benchmark configurations. The `get_configuration` function in `tests/benchmark/utils.py` will be updated to return an instance of this dataclass. All call sites for `get_configuration` will be updated to use the new dataclass object.
shuoweil
approved these changes
Jul 25, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced a new
BenchmarkConfigfrozen dataclass to provide a more structured way of handling benchmark configurations.I updated the
get_configurationfunction intests/benchmark/utils.pyto return an instance of this dataclass.I have partially updated the call sites for
get_configurationto use the new dataclass object. The following directories have been updated:The remaining call sites in
tests/benchmark/read_gbq_colab/sort_output.pyandtests/benchmark/tpch/still need to be updated.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕