Skip to content

feat: Add value_counts to GroupBy classes #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2025
Merged

feat: Add value_counts to GroupBy classes #1974

merged 5 commits into from
Aug 8, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 7, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review August 7, 2025 20:21
@TrevorBergeron TrevorBergeron requested review from a team as code owners August 7, 2025 20:21
@TrevorBergeron TrevorBergeron requested a review from shuoweil August 7, 2025 20:21
@shuoweil
Copy link
Contributor

shuoweil commented Aug 8, 2025

I would suggest we merge from main, all tests should be clean in main.

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) August 8, 2025 19:12
@TrevorBergeron TrevorBergeron merged commit 82175a4 into main Aug 8, 2025
19 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the grouped_value_counts branch August 8, 2025 19:47
@release-please release-please bot mentioned this pull request Aug 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoweil shuoweil shuoweil approved these changes

Assignees

@shuoweil shuoweil

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @shuoweil