Skip to content

feat: Support args in dataframe apply method #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Support args in dataframe apply method #2026

wants to merge 6 commits into from
+320 −56

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Aug 26, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/440342833 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 26, 2025
@jialuoo jialuoo marked this pull request as ready for review August 26, 2025 21:14
@jialuoo jialuoo requested review from a team as code owners August 26, 2025 21:14
@jialuoo jialuoo marked this pull request as draft August 26, 2025 22:05
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 26, 2025
@jialuoo jialuoo changed the title feat: Allow passing args to managed functions in DataFrame apply method feat: Allow passing args in DataFrame apply method Aug 26, 2025
@jialuoo jialuoo marked this pull request as ready for review August 26, 2025 23:57
@jialuoo jialuoo changed the title feat: Allow passing args in DataFrame apply method feat: Support args in dataframe apply method Aug 27, 2025
shobsi
shobsi reviewed Aug 27, 2025
View reviewed changes
@jialuoo jialuoo requested a review from shobsi August 28, 2025 20:33
shobsi
shobsi reviewed Aug 28, 2025
View reviewed changes
@jialuoo jialuoo requested a review from shobsi August 28, 2025 23:44
shobsi
shobsi reviewed Aug 29, 2025
View reviewed changes
tests/system/large/functions/test_remote_function.py
@@ -1958,7 +1958,8 @@ def the_sum(s1, s2, x):

# Fails to apply on dataframe with incompatible number of columns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment should reflect "columns and args"

tests/system/large/functions/test_remote_function.py
@@ -1958,7 +1958,8 @@ def the_sum(s1, s2, x):

# Fails to apply on dataframe with incompatible number of columns.
with pytest.raises(
ValueError, match="^Parameter count mismatch:.* expected 3 but received 4."
ValueError,
match="^Parameter count mismatch:.* expected 3 parameters but received 4 values.*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why we are using ".*", can't we write the full sentence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi left review comments

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

At least 1 approving review is required to merge this pull request.

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jialuoo @shobsi @liujiashang