-
Notifications
You must be signed in to change notification settings - Fork 58
perf: Improve axis=1 aggregation performance #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import pytest | ||
|
||
from bigframes.core import array_value, expression | ||
import bigframes.operations as ops | ||
import bigframes.operations.aggregations as agg_ops | ||
from bigframes.session import polars_executor | ||
from bigframes.testing.engine_utils import assert_equivalence_execution | ||
|
||
pytest.importorskip("polars") | ||
|
||
# Polars used as reference as its fast and local. Generally though, prefer gbq engine where they disagree. | ||
REFERENCE_ENGINE = polars_executor.PolarsExecutor() | ||
|
||
|
||
@pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True) | ||
def test_engines_to_array_op(scalars_array_value: array_value.ArrayValue, engine): | ||
# Bigquery won't allow you to materialize arrays with null, so use non-nullable | ||
int64_non_null = ops.coalesce_op.as_expr("int64_col", expression.const(0)) | ||
bool_col_non_null = ops.coalesce_op.as_expr("bool_col", expression.const(False)) | ||
float_col_non_null = ops.coalesce_op.as_expr("float64_col", expression.const(0.0)) | ||
string_col_non_null = ops.coalesce_op.as_expr("string_col", expression.const("")) | ||
|
||
arr, _ = scalars_array_value.compute_values( | ||
[ | ||
ops.ToArrayOp().as_expr(int64_non_null), | ||
ops.ToArrayOp().as_expr( | ||
int64_non_null, bool_col_non_null, float_col_non_null | ||
), | ||
ops.ToArrayOp().as_expr(string_col_non_null, string_col_non_null), | ||
] | ||
) | ||
assert_equivalence_execution(arr.node, REFERENCE_ENGINE, engine) | ||
|
||
|
||
@pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True) | ||
def test_engines_array_reduce_op(arrays_array_value: array_value.ArrayValue, engine): | ||
arr, _ = arrays_array_value.compute_values( | ||
[ | ||
ops.ArrayReduceOp(agg_ops.SumOp()).as_expr("float_list_col"), | ||
ops.ArrayReduceOp(agg_ops.StdOp()).as_expr("float_list_col"), | ||
ops.ArrayReduceOp(agg_ops.MaxOp()).as_expr("date_list_col"), | ||
ops.ArrayReduceOp(agg_ops.CountOp()).as_expr("string_list_col"), | ||
ops.ArrayReduceOp(agg_ops.AnyOp()).as_expr("bool_list_col"), | ||
] | ||
) | ||
assert_equivalence_execution(arr.node, REFERENCE_ENGINE, engine) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -699,6 +699,9 @@ def visit_ArrayFilter(self, op, *, arg, body, param): | |
def visit_ArrayMap(self, op, *, arg, body, param): | ||
return self.f.array(sg.select(body).from_(self._unnest(arg, as_=param))) | ||
|
||
def visit_ArrayReduce(self, op, *, arg, body, param): | ||
return sg.select(body).from_(self._unnest(arg, as_=param)).subquery() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those other methods output an array, arrayreduce produces a single scalar for each input array, so I don't think we want There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for checking! |
||
|
||
def visit_ArrayZip(self, op, *, arg): | ||
lengths = [self.f.array_length(arr) - 1 for arr in arg] | ||
idx = sg.to_identifier(util.gen_name("bq_arr_idx")) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any engine or system tests for these two new ops?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly, relying on existing aggregate axis=1 tests, though have now added some engine tests for the new ops