Skip to content

test: fix unit tests for handling drive access issues #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jan 26, 2024

I realized the unit tests added in PR 344 was hasty and did not serve the purpose. Trying to make amends with this change.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 304826407 🦕

@shobsi shobsi requested review from a team as code owners January 26, 2024 18:58
@shobsi shobsi requested a review from tswast January 26, 2024 18:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 26, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 5, 2024
@shobsi shobsi added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Feb 6, 2024
@shobsi shobsi merged commit 44bfe46 into main Feb 6, 2024
@shobsi shobsi deleted the shobs-gdrive-access-error-ut branch February 6, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants