Skip to content

refactor: Split aggregate ops from implementation #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2024
Merged

refactor: Split aggregate ops from implementation #354

merged 2 commits into from
Jan 29, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners January 27, 2024 01:52
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 27, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 27, 2024
@TrevorBergeron TrevorBergeron removed the request for review from stevewalker-de January 27, 2024 01:52
chelsea-lin
chelsea-lin approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrevorBergeron TrevorBergeron added the automerge Merge the pull request once unit tests and other checks pass. label Jan 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 99ed6c3 into main Jan 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the agg_expr branch January 29, 2024 18:12
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @chelsea-lin