Skip to content

feat: add strategy="quantile" in KBinsDiscretizer #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2024
Merged

feat: add strategy="quantile" in KBinsDiscretizer #654

merged 4 commits into from
May 7, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #310685445 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu May 2, 2024 17:37
@ashleyxuu ashleyxuu requested review from a team as code owners May 2, 2024 17:37
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 2, 2024
GarrettWu
GarrettWu reviewed May 2, 2024
View reviewed changes
@ashleyxuu ashleyxuu force-pushed the aslheyxu-quantile branch from 9e1c800 to e58acdf Compare May 7, 2024 17:21
GarrettWu
GarrettWu reviewed May 7, 2024
View reviewed changes
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c6c487f into main May 7, 2024
20 of 21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the aslheyxu-quantile branch May 7, 2024 20:24
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2024
@release-please release-please bot mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleyxuu @GarrettWu