refactor: Extract DataFrame execution to class #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68b2046 to
ef08f82
Compare
ef08f82 to
cbcf924
Compare
chelsea-lin
requested changes
Aug 14, 2024
| _MAX_CLUSTER_COLUMNS = 4 | ||
|
|
||
|
|
||
| class BigQueryCachingExecutor: |
There was a problem hiding this comment.
Could you please add some comments to briefly explain how the cached executions works.
There was a problem hiding this comment.
Added a bit of an explantation to class description.
| @@ -222,17 +223,17 @@ def add_labels(job_config, api_name: Optional[str] = None): | |||
|
|
|||
|
|
|||
| def start_query_with_client( | |||
There was a problem hiding this comment.
Can we make the Session as a class and then bq_client and metrics can be part of it?
There was a problem hiding this comment.
Would rather pass more precise context, this makes it more flexible for use in other places, and reduces circular dependency between files.
chelsea-lin
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕