Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

fix: replaces deprecated snippet #448

Merged
merged 11 commits into from
Mar 10, 2023
Merged

fix: replaces deprecated snippet #448

merged 11 commits into from
Mar 10, 2023

Conversation

chalmerlowe
Copy link
Contributor

@chalmerlowe chalmerlowe commented Mar 7, 2023

Replaces a deprecated snippet with an alternate snippet.

  • removing the code that demos schedule_transfer_run()
  • replacing with code that demos start_manual_transfer_runs()

May need to do this in several steps so that there are no gaps in the documentation status.

Fixes internal bug: #191232835

BEGIN_COMMIT_OVERRIDE
docs: Replace deprecated snippet
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. labels Mar 7, 2023
@m-strzelczyk
Copy link

You mentioned you want to replace deprecated snippets with a new snippet. I'm assuming that this is the new one and you're going to then replace the snippets in docs to include the new one, then post another PR deleting the old ones?

@chalmerlowe
Copy link
Contributor Author

@m-strzelczyk

My understanding is that to ensure that the docs remain viable, there is sometimes a multi-phase process to update the docs. I don't yet have a full handle on all the parts and pieces of that process and when they apply. But in essence, this Draft PR has the new content that I want to add to the docs (and most importantly want feedback on).

I will either remove the deprecated snippet in this same PR or in another PR according to best practice as soon as I understand it.

@m-strzelczyk
Copy link

Yes, that is correct :)

This sample looks good, we can do this in steps - first add this, then a new PR to continue.

Also, it would be nice to have some automated tests - can you add them?

@chalmerlowe chalmerlowe marked this pull request as ready for review March 9, 2023 17:53
@chalmerlowe chalmerlowe requested a review from a team as a code owner March 9, 2023 17:53
@chalmerlowe chalmerlowe requested review from a team, dandhlee and alvarowolfx March 9, 2023 17:53
@snippet-bot
Copy link

snippet-bot bot commented Mar 9, 2023

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@chalmerlowe
Copy link
Contributor Author

@m-strzelczyk
I added a test that is similar to the test used to assess the deprecated snippet.
All tests/checks pass.

@chalmerlowe chalmerlowe merged commit e2f04db into main Mar 10, 2023
@chalmerlowe chalmerlowe deleted the add-sample branch March 10, 2023 15:31
@parthea parthea added the release-please:force-run To run release-please label Mar 27, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants