Skip to content

Expose sqlalchemy_bigquery.__version__ property #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tswast opened this issue Nov 29, 2022 · 0 comments · Fixed by #534
Closed

Expose sqlalchemy_bigquery.__version__ property #533

tswast opened this issue Nov 29, 2022 · 0 comments · Fixed by #534
Assignees
@thejaredchapman @Mattix23
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Nov 29, 2022

I notice __version__ is missing from __all__ here: https://github.com/googleapis/python-bigquery-sqlalchemy/blob/main/sqlalchemy_bigquery/__init__.py

We should also add a unit test to verify that we can access the __version__ property.
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 29, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Nov 29, 2022
@thejaredchapman thejaredchapman mentioned this issue Nov 30, 2022
Merged
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 30, 2022
@thejaredchapman
chore: addressed lint issue with __version__ (#534)
4e17259 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #533  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thejaredchapman thejaredchapman

@Mattix23 Mattix23

Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: addressed lint issue with __version__ googleapis/python-bigquery-sqlalchemy
3 participants
@tswast @thejaredchapman @Mattix23