Skip to content

chore: cleanup sqlalchemy compliance test suite code #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

chore: cleanup sqlalchemy compliance test suite code #1017

wants to merge 16 commits into from

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Jan 29, 2024 •
edited
Loading

test

sharoonthomas and others added 15 commits January 10, 2024 13:42
@sharoonthomas
Merge c0016ee into c2c2958
629b0fe
@kiraksi
chore: remove code for sqlalchemy before 1_4
db03511
@kiraksi
reformatted with black:
ca2bc5e
@kiraksi
Removed sqlalchemy compliance tests from versions before 1.4
7659f8b
@kiraksi
removed code in base.py for sqlalchemy < 1.4
b06dabf
@kiraksi
Merge commit 'refs/pull/920/head' of github.com:googleapis/python-big…
aca9ee4 
…query-sqlalchemy into migration-coverage
@kiraksi
fix coverage issues in base.py
65b8ce8
@kiraksi
temporarily commented out code lines not passing coverage for testing…
0a90dd0 
… purposes
@kiraksi
replaced functions previously removed for not passing cover
717adef
@kiraksi
testing removing functions for coverage
6d0975b
@kiraksi
add no cover tag to untested code and clean up commented out functions
4f9a9af
@kiraksi
fix lint issues
7811d05
@kiraksi
black
332c47e
@kiraksi
Readded deleted tests and renamed them from deprecated names
70edf85
@kiraksi
black
1f6b887
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jan 29, 2024
@kiraksi kiraksi force-pushed the cleanup-compliance-tests-migration-new branch from ca8b333 to 9601087 Compare January 29, 2024 22:57
@kiraksi kiraksi closed this Jan 29, 2024
@kiraksi kiraksi deleted the cleanup-compliance-tests-migration-new branch January 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiraksi @sharoonthomas