Skip to content

chore: sqlalchemy test compliance suite cleanup #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Jan 29, 2024

This PR is the same as #1013, however it was merged to early, so it was reverted and now will be merged again here after #987. The other draft PRs closed were testing the new merging strategy, this is the final iteration

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jan 29, 2024
@kiraksi kiraksi changed the base branch from main to development-build-v1.11.0.dev0 January 29, 2024 23:00
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jan 29, 2024
@kiraksi kiraksi marked this pull request as ready for review January 29, 2024 23:14
@kiraksi kiraksi requested review from a team as code owners January 29, 2024 23:14
@kiraksi kiraksi requested review from alvarowolfx and removed request for a team and alvarowolfx January 29, 2024 23:14
@kiraksi kiraksi force-pushed the test-compliance-suite-cleanup branch from 2dbd940 to ac3aa6e Compare January 29, 2024 23:31
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@kiraksi kiraksi added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 29, 2024
@kiraksi kiraksi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 29, 2024
@kiraksi kiraksi merged commit 59408a5 into googleapis:development-build-v1.11.0.dev0 Jan 30, 2024
@kiraksi kiraksi deleted the test-compliance-suite-cleanup branch January 30, 2024 07:42
chalmerlowe added a commit that referenced this pull request Apr 3, 2024
…#1053)

* feat!: Support SQLAlchemy 2.0, drop support for 1.x

This patch makes this library backward incompatible for
versions of SQLAlchemy < 2.0.

Fixes #510

* constraints updated

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fixing README.rst

* fixing README.rst

* upping sqlalchemy version in constraints-3.8.txt

* adding 2.0 version restrictions to owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix for

* Updated some compliance tests for sqla2 and bq

* Addressed snippet errors

* revert bad commit

* More compliance tests checking

* reformatted with black

* Changed more compliance tests, updated requirements for testing

* Fixed attributeerror in failing sample test

* Fixed geolography test failing issue

* Minor tweaks to tests and code

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Fixed small error in compliance tests, added pip freeze for owl bot testing

* Fixed some failing compliance tests by reformatting

* Added UuidTest to compliance tests

* Moved back sqlalchemy constraints to 1.4

* Update testing/constraints-3.8.txt

* Fixed minimum version of sqlalchemy for 1.4 backwards compatibility

* Bumping support for sqlalchemy 1.4.16 for sample tests

* Bump setup.py sqlalchemy to 1.4.16

* Updated compliance sqlalchemy to 1.4.16

* Fixed broken code in last merged main, as we need to avoid duplicate entries and potential implicit joins due to identical table names

* modified tests for join order variation in 1.4 vs 2.0

* typo

* Modified one compliance StringTest thats been flaky

* Updated docs

* minor fixes to noxfile and README

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleaned up code from review, removed unnecessary code and files

* Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py

* create development release 1.11.0.dev0 branch

* chore: cleanup compliance tests for sqlalchemy migration (#1013)

* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* chore: cleanup compliance file tests after migration

* lint

* fixed small import error

---------

Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io>

* Revert "chore: cleanup compliance tests for sqlalchemy migration" (#1015)

* chore: fix coverage tests sqlalchemy 2.0 migration (#987)

* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* Readded deleted tests and renamed them from deprecated names

* black

---------

Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io>

* chore: sqlalchemy test compliance suite cleanup (#1018)

* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* Readded deleted tests and renamed them from deprecated names

* black

* chore: sqlalchemy test compliance suite cleanup code

* black

* black

---------

Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io>

* create development release 1.11.0.dev1 branch

* feat: grouping sets, rollup and cube compatibility

* create development release 1.11.0.dev2

* test commit to run kokooro tests

* removed unnecessary clause function changes, edited tests

* test basic implementation of group_by_clause and visit_label

* fixed render label as label assignment

* added test case

* reformat logic

* test commit

* create development build 1.11.0.dev3

* chore: add more grouping sets/rollup/cube tests (#1029)

* chore: add more tests for grouping functions fix

* reformatted tests

* update changelog

* revert changelog

* remove note

* don't install prerelease in compliance session

* sync owlbot

* Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py

* make results order not matter

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io>
Co-authored-by: Nishant Nayak <nishantnayak@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: kiraksi <kirnendra@google.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
Co-authored-by: Chalmer Lowe <chalmer.lowe@gmail.com>
Co-authored-by: Kira <kira.kaur.sidhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants