-
Notifications
You must be signed in to change notification settings - Fork 138
Bug: removes a compliance test that fails and replaces with unit test #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment updates.
Can you take a look at this and review/approve?
There used to be two Windowing compliance tests, the second one no longer runs. The test sequence runs the first Windowing test (
NOTE: this solves one specific Will tag this PR with the PR number for the |
Hi @chalmerlowe, thank you for taking the time to fix the flaky issue! Indeed now only the enum tests are failing. LGTM. |
This bugfix removes a sqlalchemy compliance test that expects results in sorted order, which BQ does not do using the SQL statement found in that test.
We replace that test with a related unit test to confirm that the windowing feature is correctly created in our SQL statements.
Fixes #1109 🦕
Another PR will address these issues related to Enum Errors.
#1102 🦕
#1103 🦕
#1104 🦕
#1105 🦕
#1106 🦕
#1107 🦕
#1108 🦕