Skip to content

Bug: removes a compliance test that fails and replaces with unit test #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Aug 9, 2024

This bugfix removes a sqlalchemy compliance test that expects results in sorted order, which BQ does not do using the SQL statement found in that test.
We replace that test with a related unit test to confirm that the windowing feature is correctly created in our SQL statements.

Fixes #1109 🦕

Another PR will address these issues related to Enum Errors.
#1102 🦕
#1103 🦕
#1104 🦕
#1105 🦕
#1106 🦕
#1107 🦕
#1108 🦕

Copy link

conventional-commit-lint-gcf bot commented Aug 9, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Aug 9, 2024
Copy link
Collaborator Author

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment updates.

@chalmerlowe
Copy link
Collaborator Author

@Linchin

Can you take a look at this and review/approve?

  • The new unit test is covered by Kokoro.
  • The old sqlalchemy compliance test related to Windowing is deleted/not run.

There used to be two Windowing compliance tests, the second one no longer runs. The test sequence runs the first Windowing test (test_windwo) and not the second:

.../test_dialect_compliance.py::WeCanSetDefaultSchemaWEventsTest::test_wont_work_wo_insert <- .nox/compliance/lib/python3.12/site-packages/sqlalchemy/testing/suite/test_dialect.py SKIPPED [ 99%]
.../test_dialect_compliance.py::WindowFunctionTest_bigquery+bigquery::test_window <- .nox/compliance/lib/python3.12/site-packages/sqlalchemy/testing/suite/test_select.py PASSED [100%]

NOTE: this solves one specific flaky-bot issue related to Windowing. It does not solve the other flakybot issues related to the Enum errors. I want to get this resolution on the books so we can clear out the flakybot issue. I am working in a separate PR on fixes to handle the Enum errors.

Will tag this PR with the PR number for the Enum issue as soon as possible.

@chalmerlowe chalmerlowe marked this pull request as ready for review August 12, 2024 14:54
@chalmerlowe chalmerlowe requested review from a team as code owners August 12, 2024 14:54
@chalmerlowe chalmerlowe requested a review from Neenu1995 August 12, 2024 14:54
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@Linchin
Copy link
Contributor

Linchin commented Aug 13, 2024

Hi @chalmerlowe, thank you for taking the time to fix the flaky issue! Indeed now only the enum tests are failing.

LGTM.

@Linchin Linchin merged commit 75569f4 into main Aug 13, 2024
16 of 17 checks passed
@Linchin Linchin deleted the flaky-bot-enum branch August 13, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: m Pull request size is medium.
Projects
None yet
3 participants