Skip to content

chore: added missing closing bracket #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

sambhxv
Copy link
Contributor

@sambhxv sambhxv commented Sep 28, 2024

Fixes #1119 🦕

Don't know why is it not fixed by anyone, its one of those most recognizable errors.

@sambhxv sambhxv requested review from a team as code owners September 28, 2024 10:46
@sambhxv sambhxv requested a review from tswast September 28, 2024 10:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Sep 28, 2024
@chalmerlowe
Copy link
Collaborator

@sambhxv

Don't know why is it not fixed by anyone, its one of those most recognizable errors.

As the maintainer of this repo and four more, I have limited time, energy, and resources. This has an impact on my ability to fix bugs, add new features, refactor code, improve and maintain the CI/CD pipeline, mentor staff and colleagues, troubleshoot and answer customer questions, support Google internal processes, research new technologies, educate myself on the intricacies of the five repositories I inherited, and more.

So, PRs such as this are helpful, and I appreciate your time and energy. Thank you.

@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2024
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 30, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 30, 2024
@chalmerlowe
Copy link
Collaborator

I have launched kokoro and owlbot to perform CI/CD checks on this PR.
Will come back when they are finished to see about resolving this PR.

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit aaa73aa into googleapis:main Sep 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing semicolon on the readme file directions
4 participants