test: use random suffix in DML test table #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid flakes. Also, adds a table expiration so that if cleanup fails, BigQuery will still eventually remove the table.
shollyman
approved these changes
Apr 6, 2021
tests/system/conftest.py
Outdated
| empty_table = bigquery.Table(table_id, schema=bigquery_schema) | ||
| bigquery_client.create_table(empty_table, exists_ok=True) | ||
| # Add table expiration in case cleanup fails. | ||
| empty_table.expires = datetime.datetime.utcnow() + datetime.timedelta(days=1) |
There was a problem hiding this comment.
Rather than doing this to tables individually, perhaps just set the default expiration to 1d on the bigquery_dml_dataset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid flakes. Also, adds a table expiration so that
if cleanup fails, BigQuery will still eventually remove the
table.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #111 🦕