Skip to content

docs: fix typo on credentials_info code sample #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

yugoccp
Copy link
Contributor

@yugoccp yugoccp commented Dec 2, 2024

fix typo on credentials_info code sample at README.rst

fix typo on credentials_info usage sample
@yugoccp yugoccp requested review from a team as code owners December 2, 2024 02:04
@yugoccp yugoccp requested a review from Linchin December 2, 2024 02:04
Copy link

google-cla bot commented Dec 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. samples Issues that are directly related to samples. labels Dec 2, 2024
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 2, 2024
@chalmerlowe
Copy link
Collaborator

@yugoccp
Thanks for finding and suggesting a fix for this bug. Much appreciated.
It is Google policy that submitters sign the Contributor License Agreement (CLA).
See the comment above for more details. Click the link to be taken to a more complete explanation and instructions on how to sign the CLA.

Once that is signed and the CI/CD checks (kokoro and owlbot) pass, we can get this merged in.

Thanks again.

@yugoccp
Copy link
Contributor Author

yugoccp commented Dec 2, 2024

Hi @chalmerlowe ! Signed! Thanks for the quick reply :)

@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2024
@chalmerlowe chalmerlowe added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@chalmerlowe
Copy link
Collaborator

@yugoccp

I am not clear on what might have gone wrong, but in checking the status, I am still seeing that the CLA is missing. Can you take a look again at the instructions in the comment above and make sure that everything went through on your end? The email we have associated with this PR is shown below.

Latest Scan as of 2024-12-04 07:08:42
❌ Could not find a CLA for one or more contributors

Contributor(s)
GitHub Login	Email	                State
yugoccp	        yugoccp@gmail.com	Need CLA

@Linchin
Copy link
Contributor

Linchin commented Dec 5, 2024

The CLA passed with a rerun :) Will approve now.

@Linchin Linchin merged commit 736d4a2 into googleapis:main Dec 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants