Skip to content

fix: compilation of a labeled custom FunctionElement when used in grouping #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: compilation of a labeled custom FunctionElement when used in grouping #1155

merged 2 commits into from
Jan 21, 2025

Conversation

snapiri
Copy link
Contributor

@snapiri snapiri commented Jan 19, 2025

If we have a labeled custom function that we are grouping by, and the function does not support the default dialect, we can not compile our query.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [N/A] Appropriate docs were updated (if necessary)

Fixes #1150 🦕

@snapiri snapiri requested review from a team as code owners January 19, 2025 06:49
@snapiri snapiri requested a review from alvarowolfx January 19, 2025 06:49
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 19, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Jan 19, 2025
@snapiri
fix: fix grouped labels using custom functions
87696fb 
If we have a labeled custom function that we are grouping by, and the
function does not support the `default` dialect, we can not compile our
query.
@snapiri snapiri force-pushed the 1150-Fix_grouped_label branch from 670082f to 87696fb Compare January 19, 2025 06:52
@snapiri
Copy link
Contributor Author

snapiri commented Jan 21, 2025

@tswast - I would appreciate any help with promoting this fix.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 21, 2025
tswast
tswast reviewed Jan 21, 2025
View reviewed changes
@tswast tswast changed the title [1150] Fix grouped label fix: compilation of a labeled custom FunctionElement when used in grouping Jan 21, 2025
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2025
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2025
@tswast tswast merged commit 4a0f8ad into googleapis:main Jan 21, 2025
12 checks passed
@tswast
Copy link
Collaborator

tswast commented Jan 21, 2025

Thanks so much for the contribution @snapiri !

@release-please release-please bot mentioned this pull request Jan 13, 2025
Merged
@tswast
Copy link
Collaborator

tswast commented Jan 21, 2025

This should be released as part of 1.12.1. Follow #1142 for further updates.

@snapiri
Copy link
Contributor Author

snapiri commented Jan 21, 2025

Thank you for pushing this forward @tswast !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx alvarowolfx is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation of a labeled custom FunctionElement fails when used in grouping
4 participants
@snapiri @tswast @yoshi-kokoro @chelsea-lin