Skip to content

fix: updates time partition handling #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

fix: updates time partition handling #1184

wants to merge 9 commits into from

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Apr 1, 2025 •
edited
Loading

Updates time partition handling.
Restores ability to partition by day AND adds several additional allowed partitioning schemes.

Fixes #1162 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Apr 1, 2025
@chalmerlowe chalmerlowe mentioned this pull request Apr 1, 2025
Open
@chalmerlowe
Copy link
Collaborator Author

Lint is failing in the kokoro session. all other kokoro tests pass.

@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 11, 2025
@chalmerlowe chalmerlowe marked this pull request as ready for review May 12, 2025 11:50
@chalmerlowe chalmerlowe requested review from a team as code owners May 12, 2025 11:50
@chalmerlowe chalmerlowe requested a review from leahecole May 12, 2025 11:50
@chalmerlowe chalmerlowe assigned chalmerlowe and unassigned Linchin May 12, 2025
@chalmerlowe chalmerlowe requested review from Linchin and removed request for leahecole May 12, 2025 11:50
@chalmerlowe chalmerlowe changed the title fix: exp if else test fix: updates time partition handling May 12, 2025
@Linchin
Copy link
Contributor

Linchin commented May 12, 2025

Could you add unit and system test for this change? Thanks

@chalmerlowe
Copy link
Collaborator Author

chalmerlowe commented May 13, 2025 •
edited
Loading

Could you add unit and system test for this change? Thanks

@Linchin FYI:

I am ditching this PR in deference to PR #1179

While the intent of this PR was to simplify things, it was an experiment.
And ultimately this was incomplete and the additional changes I was making locally were not coming together properly and were actually causing more complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Awaiting requested review from Linchin

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partitioning by day no longer works for DATE column
2 participants
@chalmerlowe @Linchin