Add support for STRUCT and ARRAY types. #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also called RECORD and REPEATED fields.
|
Note: I created this from the GitHub web UI. Ideally we'd add some tests for these queries to make sure this actually fixes the issue. |
|
I check out this PR, build a python whl, and tested it locally against a BQ table with nested fields. And it works! |
|
I'm adding some tests now. I need to fix one thing for arrays. |
|
@sumedhsakdeo I'm glad the fix worked for you. Thanks for trying it out! I believe this PR is ready for review now. I've added tests and updated the logic to also work for REPEATED / ARRAY types. |
|
This is fantastic. Thank you @tswast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also called RECORD and REPEATED fields.
Closes #4