Skip to content

chore: add Yoshi and BigQuery teams to sample approvers #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 13, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested a review from a team as a code owner August 13, 2021 14:47
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Aug 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 13, 2021
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@tseaver
Copy link
Contributor

tseaver commented Aug 13, 2021

@tswast I don't understand the test_reflect_select failure on 3.9. It seems flaky, mabye?

@tswast
Copy link
Collaborator Author

tswast commented Aug 13, 2021

google.api_core.exceptions.BadRequest: 400 Duplicate column names in the result are not supported when a destination table is present. Found duplicate(s): record, name, age

@jimfulton was hitting that too. The error message isn't right, since we aren't specifying a destination table. I think it is some flakiness in the backend. Since we have a job ID, I went ahead and filed internal issue 196630638 so that the backend folks can investigate.

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4553a38 into master Aug 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the tswast-patch-1 branch August 13, 2021 23:30
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants