Follow SQLAlchemy dialect attribute convention #251
Conversation
aacb492 to
0631ccc
Compare
| @@ -41,6 +41,9 @@ | |||
| BIGNUMERIC, | |||
| ) | |||
|
|
|||
| # Define a "dialect" attribute to follow the common SqlAlchemy convention assumed by some libraries that leverage SqlAlchemy. | |||
| base.dialect = dialect = BigQueryDialect | |||
There was a problem hiding this comment.
If you'd like me to write a test, please let me know what file I should add the test to.
There was a problem hiding this comment.
Thanks! I'd put this in tests/unit/test_sqlalchemy_bigquery.py.
| @@ -41,6 +41,9 @@ | |||
| BIGNUMERIC, | |||
| ) | |||
|
|
|||
| # Define a "dialect" attribute to follow the common SqlAlchemy convention assumed by some libraries that leverage SqlAlchemy. | |||
There was a problem hiding this comment.
Other SqlAlchemy dialects define a dialect attribute, including but not limited to:
- base.dialect = dialect = snowdialect.dialect
- base.dialect = dialect = mysqldb.dialect
- base.dialect = dialect = psycopg2.dialect
See additional details on why this matters at #250.
There was a problem hiding this comment.
Interesting. I wasn't aware of this. Thanks!
This is a weird way to spell this. Why not define dialect in base and import it? 🤷
|
I'll add the test... |
Well, no, I can't do that without creating a new PR. |
|
Superseded by #291 |
Sorry I didn't do this sooner -- thanks for fixing this with #291! |
Fixes #250