Skip to content

fix: supports multivalues insert feature name #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: supports multivalues insert feature name #277

wants to merge 2 commits into from

Conversation

jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #226 🦕

devbis and others added 2 commits July 22, 2021 18:47
@devbis
Fix supports_multivalues_insert feature name
1ce8dde 
This PR fixes multivalues insertion feature that was broken due to a typo
Merge remote-tracking branch 'devbis/patch-1' into devbis-Fix-support…
f9876fd 
…s_multivalues_insert-feature-name
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Aug 18, 2021
@google-cla
Copy link

google-cla bot commented Aug 18, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 18, 2021
@jimfulton
Copy link
Contributor Author

jimfulton commented Aug 18, 2021 •
edited
Loading

supersedes #224

@jimfulton jimfulton changed the title Devbis fix supports multivalues insert feature name fix: supports multivalues insert feature name Aug 18, 2021
@jimfulton jimfulton closed this Aug 18, 2021
@jimfulton jimfulton deleted the devbis-Fix-supports_multivalues_insert-feature-name branch August 18, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

supports_multivalues_insert dialect setting is mispelled.
2 participants
@jimfulton @devbis