Skip to content

fix: dialect atribute wasn't provided #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 23, 2021
Merged

fix: dialect atribute wasn't provided #291

merged 5 commits into from
Aug 23, 2021

Conversation

jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #250 🦕

@jimfulton jimfulton requested a review from a team as a code owner August 20, 2021 19:27
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Aug 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2021
@jimfulton jimfulton marked this pull request as draft August 20, 2021 19:27
@jimfulton jimfulton mentioned this pull request Aug 20, 2021
Closed
jdimatteo
jdimatteo approved these changes Aug 20, 2021
View reviewed changes
Copy link

@jdimatteo jdimatteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@jimfulton jimfulton marked this pull request as ready for review August 23, 2021 14:32
@jimfulton jimfulton merged commit 2cf05a0 into googleapis:master Aug 23, 2021
@jdimatteo jdimatteo mentioned this pull request Aug 27, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

+1 more reviewer

@jdimatteo jdimatteo jdimatteo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include a dialect attribute to better follow common SqlAlchemy conventions relied upon by SqlAlchemy libraries
3 participants
@jimfulton @tswast @jdimatteo