Skip to content

chore: use public post processor image #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 3, 2021

This PR migrates from using a private post processor image gcr.io/repo-automation-bots/owlbot-python:latest to a public one gcr.io/cloud-devrel-public-resources/owlbot-python:latest which is used by automation to update templated files across python repositories in the googleapis org.

Use the following commands to test the feature:

# Pull the latest python post processor image `gcr.io/cloud-devrel-public-resources/owlbot-python`
docker pull gcr.io/cloud-devrel-public-resources/owlbot-python:latest
# Read the digest of the post processor image `gcr.io/cloud-devrel-public-resources/owlbot-python` with the tag `latest`
docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python:latest 
# In the root of the repo, use this command to run the public post processor image 
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

The benefit is that external maintainers should now be able to run the post-processor locally and PRs should continue to be opened by automation when there are updates to templated files.

I tested the functionality in the python-datastream repository and it seems to be working correctly. If there is any issue , we can roll back to the private post processor image.

This PR also removes obsolete replacements in owlbot.py from the master->main branch migration.

@parthea parthea requested a review from a team as a code owner September 3, 2021 08:58
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Sep 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 3, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 3, 2021
@jimfulton jimfulton merged commit 853d287 into main Sep 3, 2021
@jimfulton jimfulton deleted the use-public-post-processor-image branch September 3, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants