Skip to content

fix: avoid scribbling on (reused) bind param #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2021
Merged

fix: avoid scribbling on (reused) bind param #365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0919488
fix: avoid scribbling on (reused) bind param
tseaver Oct 26, 2021
c5bcad3
Merge branch 'main' into 357-dont-tase-me-bro
gcf-merge-on-green[bot] Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sqlalchemy_bigquery/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,14 @@ def visit_bindparam(
# The NullType/known-type check has to do with some extreme
# edge cases having to do with empty in-lists that get special
# hijinks from SQLAlchemy that we don't want to disturb. :)
#
# Note that we do *not* want to overwrite the "real" bindparam
# here, because then we can't do a recompile later (e.g., first
# print the statment, then execute it). See issue #357.
#
if getattr(bindparam, "expand_op", None) is not None:
assert bindparam.expand_op.__name__.endswith("in_op") # in in
bindparam = bindparam._clone(maintain_key=True)
bindparam.expanding = False
unnest = True

Expand Down