Skip to content

test: compare schema fields instead of strings in alembic test #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 30, 2021
Merged

test: compare schema fields instead of strings in alembic test #384

merged 6 commits into from
Dec 30, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Dec 29, 2021 •
edited
Loading

…ings

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #373 🦕

@tswast tswast requested a review from a team as a code owner December 29, 2021 19:45
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Dec 29, 2021
@tswast tswast mentioned this pull request Dec 29, 2021
Closed
@tseaver tseaver changed the title test: failing alembic test compares structured objects instead of str… test: compare structured objects instead of strings in alembic test Dec 29, 2021
@tseaver tseaver changed the title test: compare structured objects instead of strings in alembic test test: compare schema fields instead of strings in alembic test Dec 29, 2021
@tswast
Copy link
Collaborator Author

tswast commented Dec 29, 2021

Alembic tests are passing, but got some errors like

sqlalchemy.exc.DatabaseError: (google.cloud.bigquery.dbapi.exceptions.DatabaseError) 400 Column x is not present in table some_table at [1:33]

in the compliance tests. Also a bunch of (new?) warnings with the latest SQLAlchemy 1.4 #385

@tswast tswast mentioned this pull request Dec 29, 2021
Closed
@tswast tswast merged commit b5a55ab into main Dec 30, 2021
@tswast tswast deleted the issue373-test_alembic_scenario branch December 30, 2021 04:11
@tswast tswast mentioned this pull request Dec 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@aucampia aucampia aucampia approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests.system.test_alembic: test_alembic_scenario failed
3 participants
@tswast @tseaver @aucampia