feat: GCP access token support #459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
tswast
reviewed
May 25, 2022
| @@ -54,6 +55,9 @@ def create_bigquery_client( | |||
| ) | |||
| credentials = credentials.with_scopes(SCOPES) | |||
| default_project = credentials.project_id | |||
| elif credentials_access_token: | |||
| credentials = oauth_credentials.Credentials(credentials_access_token) | |||
| _, default_project = google.auth.default(scopes=SCOPES) | |||
There was a problem hiding this comment.
This is potentially a slow operation. I we might consider only doing this if project_id is None. Or maybe add a if default_project is None to the if project_id is None if statement below?
|
An optional |
|
This PR is pretty stale, opting to close since there haven't been responses to the code review comments. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using a temporary GCP Access Token for authenticating.
Changelog
credentials_access_tokenforcreate_engineFixes #42 🦕