Skip to content

test: corrects a defect in the data supplied to a test #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

chalmerlowe
Copy link
Collaborator

In version 3.9 of Python (and potentially other later versions) when running the tests, one of the tests was failing.

It appears that in some of the processing in one of the dependencies, the data that is supplied to our tests was incorrect. It included characters that were not HEX characters: i.e. the t in the string data.

This replaces the string data with the string 123def.

Fixes #875

@chalmerlowe chalmerlowe requested review from a team as code owners July 10, 2023 13:13
@chalmerlowe chalmerlowe requested a review from alvarowolfx July 10, 2023 13:13
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jul 10, 2023
@parthea parthea changed the title fix: corrects a defect in the data supplied to a test test: corrects a defect in the data supplied to a test Jul 10, 2023
@parthea parthea merged commit 436b68c into main Jul 10, 2023
@parthea parthea deleted the change-to-hex-chars branch July 10, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests.unit.test_geography: test_GEOGRAPHY_ElementType failed
2 participants