-
Notifications
You must be signed in to change notification settings - Fork 138
feat!: Support SQLAlchemy 2.0, drop support for 1.x #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
581869e
to
aa4dd65
Compare
@alvarowolfx is it normal for test suite to take this long? |
Looks like the build is failing because of conflicting constraints. I can move all to 2.0. Would you like me to do that? |
09fc63a
to
fb57dee
Compare
Yes. Constraints should match the minimum version we advertise in setup.py. Thanks. |
I pushed a commit to this branch that should address the constraints issue, I believe. |
LMK if there is anything I can help with |
thanks for this PR @sharoonthomas! Let me look into why the the tests are failing. We'll need them to pass before we can submit the PR (unless they're failing because of the depreciation of 1.x). |
Hi @sharoonthomas, I was trying to force push some changes to With your permission and after you sign our Contributor Licencse Agreement (https://cla.developers.google.com) if you haven't already, do you think I'd be able to create a new pull request based from fb57dee? Thanks. |
No worries
Already signed and can open a new PR based on fb57dee |
Thanks @sharoonthomas! |
Opened #920 |
This patch makes this library backward incompatible for versions of SQLAlchemy < 2.0.
Fixes #510