Skip to content

test: update system test fixtures to create necessary tables #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2021
Merged

test: update system test fixtures to create necessary tables #96

merged 2 commits into from
Mar 24, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #94 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2021
@tswast
Copy link
Collaborator Author

tswast commented Mar 24, 2021

Note: I still expect the tests to fail due to the docs session failing: #90

@tswast
Copy link
Collaborator Author

tswast commented Mar 24, 2021

As expected:

nox > Ran multiple sessions:
nox > * unit-3.6: success
nox > * unit-3.7: success
nox > * unit-3.8: success
nox > * unit-3.9: success
nox > * system-3.8: success
nox > * cover: success
nox > * lint: success
nox > * lint_setup_py: success
nox > * blacken: success
nox > * docs: failed

@tswast tswast merged commit e9d66fb into googleapis:master Mar 24, 2021
@tswast tswast deleted the issue94-test_sqlalchemy_bigquery branch March 24, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests.system.test_sqlalchemy_bigquery: many tests failed
1 participant
@tswast