Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #90 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2021
@tswast tswast requested a review from parthea March 25, 2021 14:30
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Only one observation

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Mar 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1707737 into googleapis:master Mar 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 25, 2021
@tswast tswast deleted the issue90-docs branch March 25, 2021 15:37
@tswast tswast restored the issue90-docs branch March 25, 2021 15:37
@tswast tswast deleted the issue90-docs branch March 25, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate docs with Sphinx
2 participants