Skip to content

test: change compliance test rerun condition regex string #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 12, 2024
Merged

test: change compliance test rerun condition regex string #982

merged 13 commits into from
Jan 12, 2024

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Jan 10, 2024 •
edited
Loading

This PR tries to reproduce the system test failure recorded in #969.

This PR fixes a group of compliance tests failures opened by flaky bot: #938 ~ #1002

After investigations it seems the rerun conditions of the compliance test, which work as regex match, did not catch the intended errors as the error messages' format has changed. Updated the strings so the compliance tests pass.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@Linchin Linchin requested review from a team as code owners January 10, 2024 19:41
@Linchin Linchin requested a review from Neenu1995 January 10, 2024 19:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jan 10, 2024
@Linchin Linchin removed the request for review from Neenu1995 January 10, 2024 19:41
@Linchin Linchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 10, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jan 11, 2024
@chalmerlowe
Copy link
Collaborator

@Linchin
Two things (not sure if you already know this or not):

if we are gonna change the noxfile.py for this testing, there may be some cases where the owlbot processor may run and revert all our changes to the noxfile.

To avoid this while we test the noxfile.py changes we can apply the owlbot:ignore label.

When it comes time to make changes to owlbot.py to create any needed updates in the noxfile.py, we have a local owlbot docker container that can simplify the testing to make sure owlbot.py is successful in creating all the edits we need.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jan 11, 2024
@Linchin
Copy link
Contributor Author

Linchin commented Jan 12, 2024

@chalmerlowe

Thank you for the reminder about owlbot! I definitely forgot about it, but lucked out as owlbot somehow did not run. I'll make sure owlbot.py is modified correctly in the final PR. I'll message you individually about the details to run the owlbot container.

@parthea
Copy link
Contributor

parthea commented Jan 12, 2024

but lucked out as owlbot somehow did not run

I believe this is WAI. Owl bot won’t run automatically when PRs are created from a fork (for security reasons).

@Linchin Linchin changed the title chore: system test failure investigation test: change compliance test rerun condition regex string Jan 12, 2024
@Linchin Linchin added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@Linchin Linchin requested a review from chalmerlowe January 12, 2024 01:59
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2024
chalmerlowe
chalmerlowe approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit b11a110 into googleapis:main Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linchin @chalmerlowe @parthea