Skip to content

DO NOT MERGE: test with pre-release google-cloud-core #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: test with pre-release google-cloud-core #145

wants to merge 1 commit into from

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 23, 2020

This pull request is to check that the changes made in googleapis/python-cloud-core#28 do not break this library.

@tswast tswast requested a review from a team as a code owner September 23, 2020 15:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@tswast tswast closed this Sep 23, 2020
@tswast
Copy link
Contributor Author

tswast commented Sep 23, 2020

Closing as all tests passed without modification.

I was curious why google-cloud-bigtable uses google-cloud-core, even though it's a gRPC client. It appears to mostly (exclusively?) be for the type conversion helpers in https://github.com/googleapis/python-cloud-core/blob/master/google/cloud/_helpers.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tswast