Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Add DevPlat as CodeOwners #14

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Add DevPlat as CodeOwners #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76636f0
Update .repo-metadata.json
Shabirmean Mar 23, 2021
c3da5da
Update .repo-metadata.json to include dev-play team as codeowners
Shabirmean Mar 23, 2021
baf8566
Merge branch 'add-devplat-codeowner' of github.com:googleapis/python-…
Shabirmean Mar 23, 2021
7012a9e
Merge branch 'master' into add-devplat-codeowner
Shabirmean Mar 24, 2021
ed03c45
Update the CODEOWNERS file manually to add the DevPlat team
Shabirmean Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

# The @googleapis/yoshi-python is the default owner for changes in this repo
* @googleapis/yoshi-python
* @googleapis/yoshi-python @googleapis/cicd


/samples/ @googleapis/python-samples-owners
/samples/ @googleapis/python-samples-owners
5 changes: 3 additions & 2 deletions .repo-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
"language": "python",
"repo": "googleapis/python-binary-authorization",
"distribution_name": "google-cloud-binary-authorization",
"api_id": "binaryauthorization.googleapis.com"
}
"api_id": "binaryauthorization.googleapis.com",
"codeowner_team": "@googleapis/cicd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this team to the .github/CODEOWNERS file manually (Python doesn't currently autogen CODEOWNERS files)

If you could also file a feature request on synthtool for Python to respect codeowner_team in repo-metadata.json that would be great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the CODEOWNERS file and also filed a feature in the synthool here. Please do confirm that the feature request is what was expected and is correct.

}