This repository was archived by the owner on Dec 31, 2023. It is now read-only.
tests: add more tests required for alpha #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@busunkim96, @software-dov Can you please take a look? |
busunkim96
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
@georgiyekkert Are these tests being added to meet some requirement? Historically we haven't added extensive system tests to the GAPICs since they share the same surface.
If there isn't a specific system test requirement may be more useful to add to the samples instead. Those are more immediately usable by customers and can still act as smoke tests since they run on every PR.
|
@busunkim96 we discussed testing requirements with vam@ and vchudnov@, I believe samples will be different from these tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕