Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

chore: migrate to owl bot #33

Merged
merged 8 commits into from
May 12, 2021
Merged

chore: migrate to owl bot #33

merged 8 commits into from
May 12, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 19, 2021

No description provided.

@parthea parthea requested review from a team and tswast April 19, 2021 15:05
@product-auto-label product-auto-label bot added the api: dataqna Issues related to the googleapis/python-data-qna API. label Apr 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 19, 2021
@parthea
Copy link
Contributor Author

parthea commented Apr 19, 2021

Unit test is failing here:

    def _create_composite_credentials(
            credentials=None,
            credentials_file=None,
            scopes=None,
            ssl_credentials=None,
            quota_project_id=None):
        """Create the composite credentials for secure channels.

        Args:
            credentials (google.auth.credentials.Credentials): The credentials. If
                not specified, then this function will attempt to ascertain the
                credentials from the environment using :func:`google.auth.default`.
            credentials_file (str): A file with credentials that can be loaded with
                :func:`google.auth.load_credentials_from_file`. This argument is
                mutually exclusive with credentials.
            scopes (Sequence[str]): A optional list of scopes needed for this
                service. These are only used when credentials are not specified and
                are passed to :func:`google.auth.default`.
            ssl_credentials (grpc.ChannelCredentials): Optional SSL channel
                credentials. This can be used to specify different certificates.
            quota_project_id (str): An optional project to use for billing and quota.

        Returns:
            grpc.ChannelCredentials: The composed channel credentials object.

        Raises:
            google.api_core.DuplicateCredentialArgs: If both a credentials object and credentials_file are passed.
        """
        if credentials and credentials_file:
            raise exceptions.DuplicateCredentialArgs(
                "'credentials' and 'credentials_file' are mutually exclusive."
            )

        if credentials_file:
            credentials, _ = google.auth.load_credentials_from_file(credentials_file, scopes=scopes)
        elif credentials:
            credentials = google.auth.credentials.with_scopes_if_required(credentials, scopes)
        else:
            credentials, _ = google.auth.default(scopes=scopes)

        if quota_project_id:
>           credentials = credentials.with_quota_project(quota_project_id)
E           AttributeError: 'AnonymousCredentials' object has no attribute 'with_quota_project'

.nox/unit-3-6/lib/python3.6/site-packages/google/api_core/grpc_helpers.py:220: AttributeError

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 22, 2021
@busunkim96
Copy link
Contributor

@parthea bumping google-api-core to >=1.22.2 should fix it.

"google-api-core[grpc] >= 1.22.0, < 2.0.0dev",
and in constraints-3.6.txt.

@parthea
Copy link
Contributor Author

parthea commented May 9, 2021

Thanks! I'm going to force push the branch using the same owl bot files.

@parthea parthea requested a review from a team as a code owner May 9, 2021 13:16
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 9, 2021
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8448b04 into master May 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot branch May 12, 2021 01:30
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dataqna Issues related to the googleapis/python-data-qna API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants