Skip to content

chore: add constraints file #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 4, 2021
Merged

chore: add constraints file #144

merged 7 commits into from
Feb 4, 2021

Conversation

busunkim96
Copy link
Contributor

Add constraints file to test lower bounds. These files will not be used until the noxfile is changed in googleapis/synthtool#869.

@busunkim96 busunkim96 requested a review from a team December 30, 2020 20:56
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Dec 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
@busunkim96 busunkim96 changed the title chore: add comnstraints file chore: add constraints file Dec 30, 2020
tseaver
tseaver approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unfortunately, my review won't unblock the PR. :(

@crwilcox crwilcox merged commit f9a22c7 into master Feb 4, 2021
@crwilcox crwilcox deleted the add-constraints-file branch February 4, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @tseaver @crwilcox