tests: add coverage for skip < offset case #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwilcox
reviewed
May 18, 2021
| @@ -593,8 +593,12 @@ def _next_page(self): | |||
| # skipped all of the results yet. Don't return any results. | |||
| # Instead, rerun query, adjusting offsets. Datastore doesn't process | |||
| # more than 1000 skipped results in a query. | |||
| old_query_pb = query_pb | |||
| query_pb = query_pb2.Query() | |||
| query_pb._pb.CopyFrom(old_query_pb._pb) # copy for testability | |||
There was a problem hiding this comment.
@craiglabenz is this going to hit the bad path for perf and protoplus?
I have hesitation about making a product change to make it possible to test. Can you shed more light on this change @tseaver
There was a problem hiding this comment.
For perf:
- We are dealing with the raw protos here -- no protoplus attributes are touched, and
CopyFromis super-fast (implemented in C). - The copy will only be made once per page, in the edge case where we are skipping over more than a page of results.
For correctness:
- Scribbling on the original
query_pbis a puzzlement, and might actually defeat some forms of debugging (maybe even a full-retry of the query, if needed somehow?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #158