feat: named database support #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
320ead0 to
53095e5
Compare
rwhogg
commented
Jan 11, 2023
8e87c00 to
b88fdca
Compare
Mariatta
reviewed
Jan 18, 2023
Mariatta
reviewed
Jan 18, 2023
8c60490 to
29555fe
Compare
c864b54 to
b8a5250
Compare
Mariatta
approved these changes
Jan 27, 2023
pl04351820
reviewed
Jan 27, 2023
pl04351820
reviewed
Jan 27, 2023
6321dae to
b5a44f8
Compare
pl04351820
approved these changes
Jan 29, 2023
04690bb to
9eed6af
Compare
Mariatta
approved these changes
Feb 3, 2023
Mariatta
pushed a commit
that referenced
this pull request
May 9, 2023
* feat: Add named database support * test: Use named db in system tests
4 tasks
Mariatta
pushed a commit
that referenced
this pull request
May 9, 2023
* feat: Add named database support * test: Use named db in system tests
m-strzelczyk
pushed a commit
that referenced
this pull request
Jun 21, 2023
* feat: named database support (#398) * feat: Add named database support * test: Use named db in system tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Handle the case when client doesn't have database property * fix: add custom routing headers * Fixing tests for easier merge * fixing code coverage * addressing pr comments * feat: Multi db test parametrization (#436) * Feat: Parametrize the tests for multidb support Remove "database" argument from Query and AggregationQuery constructors. Use the "database" from the client instead. Once set in the client, the "database" will be used throughout and cannot be re-set. Parametrize the tests where-ever clients are used. Use the `system-tests-named-db` in the system test. * Add test case for when parent database name != child database name * Update owlbot, removing the named db parameter * Reverted test fixes * fixing tests * fix code coverage * pr suggestion * address pr comments --------- Co-authored-by: Vishwaraj Anand <vishwaraj.anand00@gmail.com> --------- Co-authored-by: Bob "Wombat" Hogg <wombat@rwhogg.site> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Vishwaraj Anand <vishwaraj.anand00@gmail.com> Co-authored-by: meredithslota <meredithslota@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: