deps: adds limits to numpy installs under 3.10 for dataproc #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Jul 7, 2025
There was a problem hiding this comment.
👎 on this change. I suspect dataproc's problem isn't really because of db-dtypes incompatibility but because of older pandas + newer numpy not playing nicely.
I wouldn't want to prevent all 3.10 users from using the latest numpy.
Edit: Discussed offline. Numpy already doesn't support >= 2.3.0 on Python 3.10. While this change feels redundant in that case, it shouldn't do any harm.
|
As noted in my internal chat comment. I am talking to the Dataproc team to see if there are alternatives that meet their needs but don't affect other users of this library. More to come. |
tswast
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Dataproc team requested this change.
CONTEXT:
When installing
python-bigquery[pandas](which depends onpython-db-dtypes-pandas, which depends onnumpy) an issue arises becausedb-dtypesattempts to install a version ofnumpygreater than2.2.6. Due to requirements to reproduce the Dataproc environment, they cannot allow installs ofnumpygreater than2.2.6so they requested that we add an upper limit.