Skip to content

tests: skip some system tests for mtls testing #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2020
Merged

tests: skip some system tests for mtls testing #105

merged 1 commit into from
Nov 23, 2020

Conversation

arithmetic1728
Copy link
Contributor

Skip some bigquery/storage/pubsub system test cases that don't work for mtls testing.

@arithmetic1728 arithmetic1728 requested review from a team as code owners November 23, 2020 18:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Nov 23, 2020
busunkim96
busunkim96 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please let @daniel-sanche take a look as well.

Can you create an issue to track re-enabling these tests later?

daniel-sanche
daniel-sanche reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any more context for these? The tests seem to be passing fine on kokoro, do you have a different test system somewhere that requires mTLS? Or is this for a future change to the kokoro tests?

@arithmetic1728
Copy link
Contributor Author

arithmetic1728 commented Nov 23, 2020 •
edited
Loading

@daniel-sanche There is nothing wrong with the tests or kokoro. We use a special internal testing environment to test mTLS. This PR just adds a tag so the internal testing environment can skip the tests not suitable for mTLS.

We did similar thing for python-translate lib. PR

@arithmetic1728
Copy link
Contributor Author

arithmetic1728 commented Nov 23, 2020 •
edited
Loading

LGTM, but please let @daniel-sanche take a look as well.

Can you create an issue to track re-enabling these tests later?

The tests are not skipped for kokoro. This "skip_for_mtls" tag is only for the internal mTLS testing environment.

There is no need to re-enable them (also not possible for those using storage/bigquery http clients), because the remaining tests are enough for mTLS testing purposes.

We did similar thing for python-translate lib. PR

daniel-sanche
daniel-sanche approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good, thanks!

@daniel-sanche daniel-sanche merged commit 85242c0 into master Nov 23, 2020
@arithmetic1728 arithmetic1728 deleted the sijun branch November 23, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arithmetic1728 @daniel-sanche @busunkim96