fix: Add submodule imports for handlers to logging alias #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@busunkim96 let me know if you know a more elegant way to do this |
busunkim96
reviewed
Dec 8, 2020
There was a problem hiding this comment.
This looks good to me. Could you add some unit tests to https://github.com/googleapis/python-logging/blob/master/tests/unit/test_logging_shim.py to make sure this stays in sync with logging_v2.handlers?
be7cefd to
7c16063
Compare
busunkim96
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We give users two packages:
logging_v2for the current version of the library, andloggingas the alias.We found the alias was only exporting paths at the library root, which was not what users expected. This meant they could not run
from google.cloud.logging.handlers import CloudLoggingHandler.Instead they had to run
This PR adds more
__init__.pyfiles to advertise sub-modules for the handlers. I avoided doing the same for the gapic directories (/proto,/services,/types) because we want to discourage end-users from using auto-generated codeFixes #115 🦕