Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

chore: delete migrated samples #435

Merged
merged 2 commits into from
Jan 31, 2023
Merged

chore: delete migrated samples #435

merged 2 commits into from
Jan 31, 2023

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Jan 30, 2023 •
edited
Loading

Delete samples migrated in this PR: GoogleCloudPlatform/python-docs-samples#8493

DONOT Merge until docs are updated in CL 505768167

@Sita04 Sita04 requested a review from a team as a code owner January 30, 2023 21:33
@Sita04 Sita04 requested a review from dandhlee January 30, 2023 21:33
@snippet-bot
Copy link

snippet-bot bot commented Jan 30, 2023 •
edited
Loading

Here is the summary of possible violations 😱

There are 45 possible violations for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.

You are about to delete the following sample browser pages.

Here is the summary of changes.

You are about to delete 54 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: securitycenter Issues related to the googleapis/python-securitycenter API. samples Issues that are directly related to samples. labels Jan 30, 2023
@Sita04 Sita04 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 30, 2023
dandhlee
dandhlee approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait until cl/505768167 as well as adding a README to point to the new repo as well!

@Sita04 Sita04 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 31, 2023
@Sita04 Sita04 merged commit 1a34931 into main Jan 31, 2023
@Sita04 Sita04 deleted the delete-migrated-samples branch January 31, 2023 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees
No one assigned
Labels
api: securitycenter Issues related to the googleapis/python-securitycenter API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sita04 @kweinmeister @dandhlee