Skip to content

chore: support named schemas #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 12, 2024
Merged

chore: support named schemas #1073

merged 9 commits into from
Feb 12, 2024

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jan 12, 2024 •
edited
Loading

Adds support for named schemas to the Python client library and the DB-API driver.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Jan 12, 2024
@olavloite olavloite marked this pull request as ready for review January 15, 2024 12:52
@olavloite olavloite requested review from a team as code owners January 15, 2024 12:52
@olavloite olavloite requested a review from ankiaga January 15, 2024 12:52
@olavloite
Copy link
Contributor Author

@harshachinta Do you know why the Kokoro docs-presubmit check is failing? It seems to be complaining about a dependency version mismatch, but this PR does not change anything related to that.

@parthea
Copy link
Contributor

parthea commented Jan 15, 2024

The issue with the docs should be fixed via owlbot once googleapis/synthtool#1916 is merged.

@olavloite
Copy link
Contributor Author

The issue with the docs should be fixed via owlbot once googleapis/synthtool#1916 is merged.

Ah, thanks for letting me know! 👍

@ankiaga ankiaga added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2024
ankiaga
ankiaga reviewed Jan 31, 2024
View reviewed changes
ankiaga
ankiaga reviewed Jan 31, 2024
View reviewed changes
ankiaga
ankiaga reviewed Jan 31, 2024
View reviewed changes
ankiaga
ankiaga reviewed Jan 31, 2024
View reviewed changes
ankiaga
ankiaga reviewed Jan 31, 2024
View reviewed changes
@ankiaga ankiaga enabled auto-merge (squash) February 12, 2024 06:38
@ankiaga ankiaga merged commit 2bf0319 into main Feb 12, 2024
@ankiaga ankiaga deleted the named-schemas branch February 12, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ankiaga ankiaga ankiaga approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olavloite @parthea @ankiaga @yoshi-kokoro