Skip to content

test: postgresql tests fix #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 5, 2022
Merged

test: postgresql tests fix #759

merged 13 commits into from
Jul 5, 2022

Conversation

asthamohta
Copy link
Contributor

The following runs PG tests in a parametrised manner and fixes the errors in the tests

@asthamohta asthamohta requested review from a team as code owners June 29, 2022 13:14
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Jun 29, 2022
@asthamohta asthamohta changed the title Pg tests fix test: postgresql tests fix Jun 29, 2022
@asthamohta asthamohta requested review from ansh0l and rajatbhatta June 30, 2022 06:18
IlyaFaer
IlyaFaer reviewed Jun 30, 2022
View reviewed changes
IlyaFaer
IlyaFaer reviewed Jul 1, 2022
View reviewed changes
@asthamohta asthamohta added kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2022
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2022
ansh0l
ansh0l approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asthamohta asthamohta added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2022
@asthamohta asthamohta merged commit 18c4f1f into googleapis:main Jul 5, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 5, 2022
parthea added a commit that referenced this pull request Jul 9, 2022
@parthea
update owlbot.py to apply manual changes from #759
02bb39c
parthea added a commit that referenced this pull request Jul 9, 2022
@gcf-owl-bot @parthea @asthamohta
fix: require python 3.7+ (#768)
f2c273d 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* exclude templated README

* restore manual changes to noxfile.py

* update owlbot.py to apply manual changes from #759

* regenerate pb2 files using latest version of grpcio tools

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Astha Mohta <35952883+asthamohta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaFaer IlyaFaer IlyaFaer left review comments

@ansh0l ansh0l ansh0l approved these changes

@rajatbhatta rajatbhatta Awaiting requested review from rajatbhatta

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asthamohta @ansh0l @IlyaFaer @yoshi-kokoro