Skip to content
This repository was archived by the owner on Feb 1, 2024. It is now read-only.

chore: Repo clean up code snippet that are migrated to python-docs-samples #317

Merged
merged 3 commits into from
Dec 7, 2022
Merged

chore: Repo clean up code snippet that are migrated to python-docs-samples #317

merged 3 commits into from
Dec 7, 2022

Conversation

msampathkumar
Copy link
Contributor

Repo clean up! Code samples are migrated to python-docs-samples.

For more details, check http://b/257074671

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: cloudtasks Issues related to the googleapis/python-tasks API. samples Issues that are directly related to samples. labels Nov 17, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 17, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@msampathkumar msampathkumar changed the title feat: Repo clean up - code samples are migrated to python-docs-samples feat: Repo clean up code snippet that are migrated to python-docs-samples Nov 17, 2022
@msampathkumar msampathkumar marked this pull request as ready for review November 17, 2022 22:37
@msampathkumar msampathkumar requested review from a team as code owners November 17, 2022 22:37
@snippet-bot
Copy link

snippet-bot bot commented Nov 17, 2022 •
edited
Loading

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@msampathkumar msampathkumar added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 17, 2022
@msampathkumar
Copy link
Contributor Author

A CL for updating docs is in WIP! Added don't merge label for now.

@dandhlee dandhlee changed the title feat: Repo clean up code snippet that are migrated to python-docs-samples chore: Repo clean up code snippet that are migrated to python-docs-samples Nov 17, 2022
@dandhlee
Copy link
Contributor

feat, fix or docs prefix on the PR title triggers a new release on the client library, FYI.

dandhlee
dandhlee suggested changes Nov 17, 2022
View reviewed changes
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 18, 2022
@dandhlee
Copy link
Contributor

Please request for a review once snippet-bot check is passing.

@msampathkumar
Copy link
Contributor Author

cl/489962491 and cl/492048376 are completed. Rerunning snippet bot checker now!

@dandhlee dandhlee added the snippet-bot:force-run Force snippet-bot runs its logic label Dec 1, 2022
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Dec 1, 2022
dandhlee
dandhlee reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we're deleting more files than we've migrated, can you confirm this is intentional?

@msampathkumar
Merge branch 'main' into b_257074671
21eace9 
# Conflicts:
#	samples/snippets/noxfile.py
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Dec 7, 2022
@msampathkumar msampathkumar removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2022
dandhlee
dandhlee approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit.

@dandhlee dandhlee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2022
@msampathkumar msampathkumar removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2022
@msampathkumar msampathkumar merged commit 376d8c6 into main Dec 7, 2022
@msampathkumar msampathkumar deleted the b_257074671 branch December 7, 2022 20:35
@msampathkumar msampathkumar restored the b_257074671 branch December 7, 2022 20:46
msampathkumar added a commit that referenced this pull request Dec 7, 2022
@msampathkumar
Revert "chore: Repo clean up code snippet that are migrated to python…
d09e7a1 
…-docs-samples (#317)"

This reverts commit 376d8c6.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@leahecole leahecole Awaiting requested review from leahecole leahecole was automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: cloudtasks Issues related to the googleapis/python-tasks API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msampathkumar @dandhlee