Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

chore: use gapic-generator-python 0.58.4 #121

Merged
merged 9 commits into from
Feb 15, 2022
Merged

chore: use gapic-generator-python 0.58.4 #121

merged 9 commits into from
Feb 15, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 31, 2021 •
edited by parthea
Loading

  • Regenerate this pull request now.
    fix: rename mapping attribute of AudioStream to mapping_
    fix: resolve issue where mapping attribute of AudioStream could not be set
    fix(deps): require proto-plus >= 1.20.1

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

BEGIN_COMMIT_OVERRIDE
fix: rename mapping attribute of AudioStream to mapping_

fix: resolve issue where mapping attribute of AudioStream could not be set

fix(deps): require proto-plus >= 1.20.1
END_COMMIT_OVERRIDE

@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 31, 2021 04:00
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 31, 2021
@product-auto-label product-auto-label bot added the api: transcoder Issues related to the googleapis/python-video-transcoder API. label Dec 31, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 31, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 31, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 31, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 31, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 31, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Jan 8, 2022

Owl bot is regenerating pull request 121...
Build name: NmQyNGQ2MGYtOTdhZC00ZGNjLWI1MzEtZTc0YWY2YTE5MGFk

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-fdf10352-df6e-48cf-a6ce-f3969506dcc1 branch from 22e40a9 to 8ff513b Compare January 8, 2022 00:49
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Jan 8, 2022

Owl bot is regenerating pull request 121...
Build name: NDdlYzliMTctZDEwMS00OWMyLThiNTctMDE1NGE2OTgxZGRk

@gcf-owl-bot
chore: use gapic-generator-python 0.58.4
3eff23c 
fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-fdf10352-df6e-48cf-a6ce-f3969506dcc1 branch from 4a76da2 to 3eff23c Compare January 8, 2022 10:45
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2022
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2022
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 15, 2022
@parthea
Copy link
Contributor

parthea commented Feb 15, 2022 •
edited
Loading

There are 2 tests failing with ValueError: Protocol message TextStream has no "mapping" field. however I'm unable to reproduce it locally.

partheniou@partheniou:~/git/python-video-transcoder/samples/snippets$ nox -s py-3.9 -- -k test_create_job_with_embedded_captions
No user noxfile_config found: detail: No module named 'noxfile_config'
nox > Running session py-3.9
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/py-3-9
nox > python -m pip install -r requirements.txt
nox > python -m pip install -r requirements-test.txt
nox > pytest --junitxml=sponge_log.xml -k test_create_job_with_embedded_captions
=============================================================================================================================== test session starts ================================================================================================================================
platform linux -- Python 3.9.9, pytest-6.2.4, py-1.11.0, pluggy-0.13.1
rootdir: /usr/local/google/home/partheniou/git/python-video-transcoder
collected 11 items / 10 deselected / 1 selected                                                                                                                                                                                                                                    

job_test.py .                                                                                                                                                                                                                                                                [100%]

-------------------------------------------------------------------------------- generated xml file: /usr/local/google/home/partheniou/git/python-video-transcoder/samples/snippets/sponge_log.xml ---------------------------------------------------------------------------------
======================================================================================================================== 1 passed, 10 deselected in 39.61s =========================================================================================================================
nox > Session py-3.9 was successful.

partheniou@partheniou:~/git/python-video-transcoder/samples/snippets$ nox -s py-3.9 -- -k test_create_job_with_standalone_captions
No user noxfile_config found: detail: No module named 'noxfile_config'
nox > Running session py-3.9
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/py-3-9
nox > python -m pip install -r requirements.txt
nox > python -m pip install -r requirements-test.txt
nox > pytest --junitxml=sponge_log.xml -k test_create_job_with_standalone_captions
=============================================================================================================================== test session starts ================================================================================================================================
platform linux -- Python 3.9.9, pytest-6.2.4, py-1.11.0, pluggy-0.13.1
rootdir: /usr/local/google/home/partheniou/git/python-video-transcoder
collected 11 items / 10 deselected / 1 selected                                                                                                                                                                                                                                    

job_test.py .                                                                                                                                                                                                                                                                [100%]

-------------------------------------------------------------------------------- generated xml file: /usr/local/google/home/partheniou/git/python-video-transcoder/samples/snippets/sponge_log.xml ---------------------------------------------------------------------------------
======================================================================================================================== 1 passed, 10 deselected in 39.81s =========================================================================================================================
nox > Session py-3.9 was successful.

@parthea
Copy link
Contributor

parthea commented Feb 15, 2022

I've confirmed that the test pass locally. We may need to release a new version to get samples to pass.

partheniou@partheniou:~/git/python-video-transcoder/samples/snippets$ nox -s py-3.9
No user noxfile_config found: detail: No module named 'noxfile_config'
nox > Running session py-3.9
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/py-3-9
nox > python -m pip install -r requirements.txt
nox > python -m pip install -r requirements-test.txt
nox > pytest --junitxml=sponge_log.xml
=============================================================================================================================== test session starts ================================================================================================================================
platform linux -- Python 3.9.9, pytest-6.2.4, py-1.11.0, pluggy-0.13.1
rootdir: /usr/local/google/home/partheniou/git/python-video-transcoder
collected 11 items                                                                                                                                                                                                                                                                 

job_template_test.py .                                                                                                                                                                                                                                                       [  9%]
job_test.py ..........                                                                                                                                                                                                                                                                             [100%]

------------------------------------------------------------------------------------------- generated xml file: /usr/local/google/home/partheniou/git/python-video-transcoder/samples/snippets/sponge_log.xml --------------------------------------------------------------------------------------------
===================================================================================================================================== 11 passed in 363.64s (0:06:03) =====================================================================================================================================
nox > Session py-3.9 was successful.

@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 15, 2022
@parthea parthea merged commit c14695b into main Feb 15, 2022
@parthea parthea deleted the owl-bot-fdf10352-df6e-48cf-a6ce-f3969506dcc1 branch February 15, 2022 01:49
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 15, 2022
@release-please release-please bot mentioned this pull request Feb 15, 2022
Merged
@ipotuzhnov
Copy link

@parthea Thanks a lot for resolving this issue! Our customers will appreciate your work.

@breogangf
Copy link

@parthea Amazing! Thanks a lot!

@atulep atulep mentioned this pull request Jan 24, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@ipotuzhnov ipotuzhnov ipotuzhnov approved these changes

Assignees
No one assigned
Labels
api: transcoder Issues related to the googleapis/python-video-transcoder API. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@breogangf @busunkim96 @ipotuzhnov @parthea @yoshi-kokoro @software-dov