Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

chore: move samples from GoogleCloudPlatform/python-docs-samples #125

Merged
merged 3 commits into from
Jan 24, 2022
Merged

chore: move samples from GoogleCloudPlatform/python-docs-samples #125

merged 3 commits into from
Jan 24, 2022

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Jan 15, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@irataxy irataxy requested a review from a team as a code owner January 15, 2022 00:45
@product-auto-label product-auto-label bot added the api: transcoder Issues related to the googleapis/python-video-transcoder API. label Jan 15, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jan 15, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 16 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 15, 2022
@irataxy irataxy requested a review from nicain January 15, 2022 00:45
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2022
@parthea
Copy link
Contributor

parthea commented Jan 18, 2022

Hi @nicain , Please could you review/approve?

nicain
nicain approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@nicain nicain added kokoro:force-run Add this label to force Kokoro to re-run the tests. lang: python Issues specific to Python. labels Jan 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2022
@busunkim96 busunkim96 changed the title feat: move samples from GoogleCloudPlatform/python-docs-samples chore: move samples from GoogleCloudPlatform/python-docs-samples Jan 24, 2022
dandhlee
dandhlee reviewed Jan 24, 2022
View reviewed changes
README.rst
Next Steps
~~~~~~~~~~

- See the [Samples](./samples/snippets/README.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this link doesn't seem to show up properly, but feel free to address this in a different PR.

@busunkim96
Copy link
Contributor

Thanks for moving these here! Please make sure to adjust any references to the samples in the docs published to cloud.google.com before deleting the ones in python-docs-samples.

@busunkim96 busunkim96 merged commit 66c5810 into googleapis:main Jan 24, 2022
@irataxy irataxy mentioned this pull request Jan 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dandhlee dandhlee dandhlee left review comments

@nicain nicain nicain approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@nicain nicain

Labels
api: transcoder Issues related to the googleapis/python-video-transcoder API. lang: python Issues specific to Python. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@irataxy @parthea @busunkim96 @nicain @dandhlee @yoshi-kokoro