Skip to content

fix: Dynamically set CallCredentials to CallOptions #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Dynamically set CallCredentials to CallOptions #3671

wants to merge 1 commit into from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Mar 3, 2025

[Draft] Investigate setting CallCredentials to CallOptions only if ChannelCredentials do not exist

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 3, 2025
@lqiu96 lqiu96 mentioned this pull request Mar 3, 2025
Merged
@lqiu96 lqiu96 force-pushed the grpc-channel-credentials branch from 4e2c2a5 to f137942 Compare March 3, 2025 20:55
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@lqiu96 lqiu96 closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lqiu96