Skip to content

test: Reduce the LRO timeout value in Showcase tests #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

blakeli0
Copy link
Collaborator

@blakeli0 blakeli0 commented Mar 7, 2025

fixes: #3277

I run the flaky test locally 1000 times but couldn't reproduce the issue. Despite that, reduce the LRO timeout values in the Showcase test ITLongRunningOperation.testHttpJson_LROUnsuccessfulResponse_exceedsTotalTimeout_throwsDeadlineExceededException could make the test scenario fail fast and less flaky.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 7, 2025
@blakeli0 blakeli0 requested review from lqiu96 and zhumin8 March 7, 2025 22:36
Copy link

sonarqubecloud bot commented Mar 7, 2025

Copy link

sonarqubecloud bot commented Mar 7, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
showcase-clirr failure should be unrelated, might need a separate fix:
/home/runner/work/_temp/7075eb00-7c0c-4b3b-88dc-8f5836aae34a.sh: line 3: cd: showcase: No such file or directory

@blakeli0 blakeli0 merged commit 0932605 into main Mar 10, 2025
50 of 52 checks passed
@blakeli0 blakeli0 deleted the fix-flaky-test branch March 10, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gapic-showcase: ITLongRunningOperation flaky tests
3 participants